Fix use of deprecated flask.ext imports #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flask.ext has been deprecated for years now and has been logging a warning to console ever since. OctoPrint 1.4.1 had to update the flask dependencies due to security considerations and with the new flask version the old compatibility layer still allowing flask.ext to work got removed. See also the discussion in OctoPrint/OctoPrint#3638 Closes fabianonline#269
szobov
added a commit
to szobov/OctoPrint-Telegram
that referenced
this pull request
Jul 28, 2020
I took this changes from fabianonline#270
louispires
approved these changes
Jul 29, 2020
louispires
approved these changes
Jul 29, 2020
|
Sorry having to ping y'all again but I see that while this has been merged, a new release including it hasn't been cut yet. I currently plan to push out OctoPrint 1.4.1 out tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flask.exthas been deprecated for years now and should actually have been logging a warning to console ever since too. OctoPrint 1.4.1 had to update the flask dependencies due to security considerations and in the new flask version the old compatibility layer still allowingflask.extto work got removed.Which means this plugin no longer will load on OctoPrint 1.4.1+ unless this PR gets merged and a new release (1.5.1?) pushed out.
See also the discussion in OctoPrint/OctoPrint#3638
Closes #269